Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: change all the MySQL version from 5.7.10 to 5.7.25 #9553

Merged
merged 6 commits into from
Mar 7, 2019
Merged

docs: change all the MySQL version from 5.7.10 to 5.7.25 #9553

merged 6 commits into from
Mar 7, 2019

Conversation

XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Mar 5, 2019

What problem does this PR solve?

Change all the MySQL version from 5.7.10 to 5.7.25.
related PR: pingcap/parser#231

What is changed and how it works?

N/A

Check List

Tests

  • Manual test
    Start a new tidb-server and connect to it from MySQL-client:
Reading table information for completion of table and column names
You can turn off this feature to get a quicker startup with -A

Welcome to the MySQL monitor.  Commands end with ; or \g.
Your MySQL connection id is 2
Server version: 5.7.25-TiDB-v3.0.0-beta-152-g5ad33c88d-dirty MySQL Community Server
(Apache License 2.0)
...

Code changes

N/A

Side effects

Related changes

N/A

@XuHuaiyu XuHuaiyu mentioned this pull request Mar 5, 2019
Merged
eurekaka
eurekaka reviewed Mar 5, 2019
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 5, 2019
@zz-jason
Copy link
Member

zz-jason commented Mar 5, 2019

LGTM

Please fix go mod tidy

@codecov-io
Copy link

codecov-io commented Mar 5, 2019 •
edited
Loading

Codecov Report

Merging #9553 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9553      +/-   ##
==========================================
- Coverage   67.32%   67.31%   -0.02%     
==========================================
  Files         376      376              
  Lines       78967    78967              
==========================================
- Hits        53162    53153       -9     
- Misses      21052    21059       +7     
- Partials     4753     4755       +2
Impacted Files Coverage Δ
store/tikv/2pc.go 77.7% <0%> (-1.77%) ⬇️
executor/join.go 79.06% <0%> (-0.52%) ⬇️
executor/aggregate.go 79.11% <0%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c008460...7536677. Read the comment docs.

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 6, 2019
@jackysp
Copy link
Member

jackysp commented Mar 6, 2019

/run-all-tests

@jackysp
Copy link
Member

jackysp commented Mar 6, 2019

This case testInnodbTablespaceEncryption failed in jdbc test.
Because we upgrade the version and this check passed,

if (!versionMeetsMinimum(5, 7, 11)) {
            return;
}

but, TiDB doesn't support

CREATE TABLE testInnodbTablespaceEncryption (id INT) ENCRYPTION='y'

this statement.

@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Mar 6, 2019

/run-common-test tidb-test=pr/749

@zz-jason
Copy link
Member

zz-jason commented Mar 7, 2019

/run-all-tests

@zz-jason zz-jason merged commit b3ccefc into pingcap:master Mar 7, 2019
@XuHuaiyu XuHuaiyu deleted the mysql_version branch April 22, 2019 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurekaka eurekaka eurekaka left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
component/docs status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XuHuaiyu @zz-jason @codecov-io @jackysp @eurekaka